[wp-trac] [WordPress Trac] #16628: Parent or Child Themes for Post Formats?

WordPress Trac wp-trac at lists.automattic.com
Sun Feb 27 22:51:17 UTC 2011


#16628: Parent or Child Themes for Post Formats?
---------------------------------+----------------------
 Reporter:  Lorelle              |       Owner:
     Type:  defect (bug)         |      Status:  closed
 Priority:  normal               |   Milestone:
Component:  Post Types           |     Version:  3.1
 Severity:  normal               |  Resolution:  invalid
 Keywords:  needs-testing close  |
---------------------------------+----------------------
Changes (by nacin):

 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 Replying to [comment:3 Lorelle]:
 > I searched throughout the Theme's code and can't find anything to
 override the call to the post formats. I continue to look, and it
 continues to only work in the Child Theme, not the Parent. Somehow, it
 isn't being inherited to the Child Theme. I'll be testing it this week
 with other Themes.

 Post formats are inherited from the parent theme.

 Calling add_theme_support() for post formats in the child theme will
 override the existing list, not add to it. Calling remove_theme_support
 ('post-formats') will remove it all together.

 If neither of these techniques work, then you're calling it too early.
 You'll probably need to wait until the after_setup_theme hook, priority
 11. (Twenty Ten calls this at priority 10.)

 > On GaryJ's point, I believe that post format support must be set in the
 Parent Theme, especially when it comes to multisite or blog networks using
 Child Themes per blog. While the Child Theme should have rights to
 overwrite the Parent settings for Post Formats, it should be set by the
 Parent.

 Yes. Any kind of theme can leverage post formats.

 > Hopefully soon there will be a Setting to manage post formats from the
 UI as this messing with the Theme code is very messy as placement of the
 post formats code must be done very specifically, allowing for Child Blogs
 on a network to pick and choose their options. Having a setting that would
 allow choosing the post format types and adding a touch of CSS to style
 the chosen ones would make all WordPress Themes be open to this option and
 not just those with the feature installed. Dreaming.

 I don't see the point in a UI option here at all. If a parent theme wants
 to create a set of UI options for what it wishes to support, it can do so,
 and that makes sense in some situations. But not in core.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16628#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list