[wp-trac] [WordPress Trac] #16611: Too few arguments to sprintf in WP_List_Table::comments_bubble()

[WordPress Trac]

#16611: Too few arguments to sprintf in WP_List_Table::comments_bubble()
------------------------------+------------------
 Reporter:  nacin             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  high              |   Milestone:  3.1
Component:  General           |     Version:  3.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------
Changes (by nacin):

 * keywords:  has-patch => has-patch commit


Comment:

 I was wondering why we were using comments_number() like this.

 In 3.0, we had code that looked like the red in r15504 -- basically,
 massive strings going into comments_number(). We also didn't wrap the link
 in admin_url(), thus we had no extra percentages to screw things up.
 sprintf() plus admin_url(), two pretty innocuous changes, caused the
 regression.

 The smarter structuring in r15504 in turn revealed that
 get_comments_number() is a better approach.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16611#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software