[wp-trac] [WordPress Trac] #16586: Don't fire the wp_enqueue_scripts hook on wp-login.php
WordPress Trac
wp-trac at lists.automattic.com
Fri Feb 18 02:27:39 UTC 2011
#16586: Don't fire the wp_enqueue_scripts hook on wp-login.php
--------------------------+-----------------
Reporter: nacin | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.1
Component: Template | Version: 3.1
Severity: normal | Keywords:
--------------------------+-----------------
admin_print_scripts and wp_enqueue_scripts actions are ideally where
wp_enqueue_script() calls should be attached to -- one for the admin, and
one for the theme.
[16000] attached wp_enqueue_scripts() to login_head, which is a wrapper
function to fire the wp_enqueue_scripts action. This means that a theme
attaching a script to the frontend via wp_enqueue_scripts -- even if
wrapped in an unnecessary is_admin() check -- will get their JS printed on
the login form. This has the potential to throw JS errors, which is what
happens in P2 for example.
The fix is to come up with a new action name.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16586>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list