[wp-trac] [WordPress Trac] #16547: suppressed PHP Warning on Install Plugins table

[WordPress Trac]

#16547: suppressed PHP Warning on Install Plugins table
---------------------------------+-----------------------------
 Reporter:  dd32                 |       Owner:  dd32
     Type:  defect (bug)         |      Status:  accepted
 Priority:  normal               |   Milestone:  Future Release
Component:  Plugins              |     Version:  3.0
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 3.2-early  |
---------------------------------+-----------------------------
Description changed by dd32:

Old description:

> When browsing potential plugins to install, If a plugin is installed,
> it'll trigger a Notice. This notice is suppressed by @, Thank you Debug
> bar for debugging the buged.
>
> In this case, It looks like the closedir() calls need to be placed in
> batter spots, ideally, after the directory resource is finished being in
> use, see patch.
>
> This is in no-way a recent bug, and appears to have been introduced a
> long time ago.

New description:

 When browsing potential plugins to install, If a plugin is installed,
 it'll trigger a Notice. This notice is suppressed by @, Thank you Debug
 bar for debugging the buged.

 One is caused by closedir() being called with a null param
 ($plugin_subdir) - which is caused by the fact that it's not set in all
 cases. If the function never deals with a folder with a subdirectory, then
 it'll be unset.

 In this case, It looks like the closedir() calls need to be placed in
 batter spots, ideally, after the directory resource is finished being in
 use, see patch.

 This is in no-way a recent bug, and appears to have been introduced a long
 time ago.

--

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16547#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software