[wp-trac] [WordPress Trac] #16501: 'Add Existing' button should be dependent on is_multisite

[WordPress Trac]

#16501: 'Add Existing' button should be dependent on is_multisite
------------------------------+------------------
 Reporter:  nacin             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.1
Component:  Role/Capability   |     Version:
 Severity:  major             |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------
Changes (by nacin):

 * keywords:   => has-patch commit


Comment:

 I gave MarkJaquith a walkthrough in IRC (posted below). Want ryan and
 westi to as well.

 wp-admin/user.php: First piece, add an additional promote_users cap check
 before the promote_user meta cap checks in the post handler for bulk
 action promotions.

 Second piece, don't show the 'Add Existing' button in single-site mode
 when you can't create new users. (All users are shown even if they don't
 have a blog, such as shared user tables.)

 wp-users-list-table: Don't show the bulk actions if you can't
 promote_users. It doesn't work post-side.

 wp-admin/user-new.php: Check my logic, but — deny if you don't have
 create_users. Exception is that on multisite, you can be missing
 create_users but have promote_users.

 wp-admin/menu.php: We need user-new.php accessible for those who have
 create_users but not promote_users. Trick is to do a cap check then pass
 the right cap to $submenu.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16501#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software