[wp-trac] [WordPress Trac] #19695: Links widget does not generate width or height attributes when showing an image
WordPress Trac
wp-trac at lists.automattic.com
Fri Dec 30 17:36:40 UTC 2011
#19695: Links widget does not generate width or height attributes when showing an
image
------------------------------------------------+--------------------------
Reporter: mbijon | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Widgets | Review
Severity: normal | Version: 3.3
Keywords: dev-feedback 2nd-opinion has-patch | Resolution:
------------------------------------------------+--------------------------
Comment (by ericmann):
GD isn't a requirement, but this is the same way we handle it elsewhere.
And, coming from having accidentally installed PHP at least once
''without'' GD, I can tell you that having notices like this in there is a
lifesaver. It took me about 2 weeks to figure out why thumbnails weren't
being auto-generated.
I mirrored my patch after the other patterns we follow when using
{{{getimagesize()}}} in core for consistency. If one of the core leads
wants to step in with an opinion, I'd be fine going either way, really.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/19695#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list