[wp-trac] [WordPress Trac] #17044: div.wp-caption shortcode should have width of img, rather than add +10px

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 30 03:27:47 UTC 2011


#17044: div.wp-caption shortcode should have width of img, rather than add +10px
-------------------------------+------------------------------
 Reporter:  mgk25              |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Shortcodes         |     Version:  3.1
 Severity:  normal             |  Resolution:
 Keywords:  close 2nd-opinion  |
-------------------------------+------------------------------

Comment (by azaozz):

 Replying to [comment:6 greenshady]:

 The 10px are there to allow adding border to the wrapper so captions on
 the front-end look similar to captions in the visual editor. That was long
 before themes started to style the visual editor, even before browsers
 were supporting stuff like `box-sizing: border-box;` etc.

 Frankly I don't see why the extra 5px on each side of the image are such a
 problem. It's not necessary to add border to the wrapping div or the
 padding can be adjusted after taking the 5px into consideration. Themes
 that want to have full control can replace the whole [caption] shortcode
 rendering, adding/removing/modifying anything they like.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17044#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list