[wp-trac] [WordPress Trac] #19655: I fixed a piece of code that used a hack instead of basename()

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 23 17:19:28 UTC 2011


#19655: I fixed a piece of code that used a hack instead of basename()
-------------------------+-----------------------------
 Reporter:  BaylorRae    |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  Themes       |    Version:  3.3
 Severity:  normal       |   Keywords:  has-patch
-------------------------+-----------------------------
 Hello I was browsing the source of WordPress `wp-admin/includes/theme.php`
 and noticed that it used str_replace() instead of basename().

 I've attached my `basename-patch.diff` file and the updated `theme.php`
 file for someone to look over.

 ---[[BR]]
 This is my first time to contribute to WP. I tried to make a commit with
 SVN but I get a forbidden access error. If you have any suggestions please
 help.

 svn: Commit failed (details follow):[[BR]]
 svn: access to '/!svn/act/33767141-9196-41b2-926e-d24cd5f0aa35' forbidden

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19655>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list