[wp-trac] [WordPress Trac] #17122: Set smiley conversion to disabled by default

[WordPress Trac]

#17122: Set smiley conversion to disabled by default
---------------------------------------+------------------
 Reporter:  joostdevalk                |       Owner:
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  3.4
Component:  General                    |     Version:
 Severity:  minor                      |  Resolution:
 Keywords:  easy-fix has-patch commit  |
---------------------------------------+------------------

Comment (by sksmatt):

 Replying to [comment:7 dd32]:

 > Patch looks great.

 Thank you!

 Replying to [comment:8 nacin]:

 > On commit, I'm thinking that instead of deleting the line, we should
 comment it out with a note, that way people know that A) it exists and B)
 it was deliberately disabled due to potential conflicts with regular text.

 Would this be consider an appropriate comment style for this case?:
 {{{
      ';-)' => 'icon_wink.gif',
      /*
      *  NOTE: deliberately disabled due to potential conflicts with
 regular text.
      *  The file exists and is available.
      *
      *  '8)' => 'icon_cool.gif',
      */
      '8O' => 'icon_eek.gif',
 }}}

 Also, I made some note variations as english grammar is not my strongest
 suit. Let me know if one of the following would do:

 a)
 Deliberately disabled due to potential conflicts with regular text. The
 file exists and is available.

 b)
 The following file exists but the smiley has been deliberately disabled
 due to potential conflicts with regular text.

 c)
 The file exists but the smiley has been deliberately disabled due to
 potential conflicts with regular text.

 d)
 The following smiley has been deliberately disabled due to potential
 conflicts with regular text but the file is still available.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17122#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software