[wp-trac] [WordPress Trac] #19579: Make get_search_form() more filterable/extensible

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 16 16:06:21 UTC 2011


#19579: Make get_search_form() more filterable/extensible
-------------------------------------+------------------------------
 Reporter:  chipbennett              |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Template                 |     Version:  3.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------

Comment (by GaryJ):

 Replying to [comment:2 chipbennett]:
 > Replying to [comment:1 toscho]:
 > >
 > > There should be a space between the input '''elements'''.
 > >
 >
 > Isn't there? I'm imploding the '''atts''' arrays with spaces before
 outputting them in the HTML markup.

 He's talking about the elements, not the attributes. I think I disagree
 though - visual whitespace can be added with CSS, and I'm not aware of any
 accessibility issues with them following right on from each other within
 the markup. Easier for developers to add some margin between the elements,
 than having to filter the output just to trim extra spaces that is being
 suggested to be added.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19579#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list