[wp-trac] [WordPress Trac] #19579: Make get_search_form() more filterable/extensible

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 16 15:54:02 UTC 2011


#19579: Make get_search_form() more filterable/extensible
-------------------------------------+------------------------------
 Reporter:  chipbennett              |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Template                 |     Version:  3.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------

Comment (by chipbennett):

 Replying to [comment:1 toscho]:
 > `label` and `placeholder` are different things. Imagine a screenreader
 user listening to: ''Search for: Search''.
 >
 > ''Enter one or more search terms'' would be slightly better; usually you
 just don’t need a placeholder.
 >

 I'm open to direction on this. Basically, I just incorporated #16538.
 What's the best approach?

 >
 > There should be a space between the input elements.
 >

 Isn't there? I'm imploding the atts arrays with spaces before outputting
 them in the HTML markup.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19579#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list