[wp-trac] [WordPress Trac] #19420: get_blog_permalink() can cache either an HTTP or HTTPS link for the same post

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 2 22:28:18 UTC 2011


#19420: get_blog_permalink() can cache either an HTTP or HTTPS link for the same
post
--------------------------+-----------------------------
 Reporter:  mdawaffe      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Multisite     |    Version:  3.3
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------------
 {{{get_home_url()}}} can return an HTTP or HTTPS URL based on an
 {{{is_ssl() && !is_admin()}}} check.

 {{{get_permalink()}}} uses {{{home_url()}}} to construct the permalink.

 {{{get_blog_permalink()}}} caches the result of {{{get_permalink()}}}.

 When using a persistent cache, this can lead to an inconsistent cache and
 cause unexpected results.

 Suggestion: always cache the link as HTTP.  Add a filter to the return
 value so that sites can adjust things as needed for their specific
 scenarios.

 Patch attached.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19420>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list