[wp-trac] [WordPress Trac] #19371: As of 3.3beta2 WP_Admin_Bar no longer provides a way to access attributes of existing menu items

WordPress Trac wp-trac at lists.automattic.com
Thu Dec 1 17:02:07 UTC 2011


#19371: As of 3.3beta2 WP_Admin_Bar no longer provides a way to access attributes
of existing menu items
------------------------------+---------------------
 Reporter:  willshouse        |       Owner:  nacin
     Type:  defect (bug)      |      Status:  closed
 Priority:  high              |   Milestone:  3.3
Component:  Admin Bar         |     Version:  3.3
 Severity:  minor             |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------

Comment (by nacin):

 Replying to [comment:25 willshouse]:
 > We are also missing the other part of scribu's contribution (and my
 !empty part)

 I addressed this above:
 > Second thought: Since we have get_node(), I'm going to avoid
 remove_node() returning anything.

 It's not a typical construct for us to return something from a removal
 function. While it's clever, I think it is more clear to rely on
 get_node(), now that we have it.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19371#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list