[wp-trac] [WordPress Trac] #18467: Redirect to About WordPress page after upgrade

WordPress Trac wp-trac at lists.automattic.com
Thu Dec 1 03:06:18 UTC 2011


#18467: Redirect to About WordPress page after upgrade
-----------------------------+-----------------------
 Reporter:  sparkweb         |       Owner:  nacin
     Type:  task (blessed)   |      Status:  accepted
 Priority:  normal           |   Milestone:  3.3
Component:  Upgrade/Install  |     Version:  3.3
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+-----------------------

Comment (by nacin):

 [attachment:18467.diff]:

  * '''Debug Code''' — Includes debugging code. Specifically, the
 window.location bits are commented out and files are not copied. This
 means your install will not be overridden with the nightly, and your in
 situ wp-admin/includes/update-core.php will be used.

  * Includes no-JS support – namely, a separate string. The no-JS string
 looks like this:

   Welcome to WordPress %1$s. You will be redirected to the About WordPress
 screen. If not, click <a href="%s">here</a>.

  * The with-JS string looks like this:

   Welcome to WordPress %1$s. <a href="%2$s">Learn more</a>.

  * As discussed with ocean90 and duck_, I made it so
 _redirect_to_about_wordpress() only fires when the current install is <
 3.3. Once the install is 3.3, the new strings will be in the POT file, and
 the new code will be in place in wp-admin/update-core.php.

  * I needed to alter the return of wp_update_core() to include the *new*
 version number, otherwise I couldn't do the previous bullet point. This
 makes me second-guess the previous bullet point as unnecessary.

  * In multisite, about.php?updated now links back to the network/update-
 core.php file.

 Thoughts?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18467#comment:32>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list