[wp-trac] [WordPress Trac] #18180: Missing i18n in setup-config.php

Mon Aug 29 15:38:16 UTC 2011

#18180: Missing i18n in setup-config.php
-------------------------+-----------------------
 Reporter:  CoenJacobs   |       Owner:  nacin
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  3.3
Component:  I18N         |     Version:  3.2.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Comment (by SergeyBiryukov):

 Some suggestions:

 * Since we already have `version.php` included, couldn't we just use
 `$wp_local_package` if it's set?
 * `$text_direction` is set in `WP_LANG_DIR . "/$locale.php"`, so I guess
 we need to include that file if it exists.
 * `install.css` is changed to `install.dev.css`. Is that intentional?
 * Do we actually need to allow apostrophes in `DB_HOST`? We didn't touch
 it in #13839, so I guess we should allow them only in `DB_NAME`, `DB_USER`
 and `DB_PASSWORD`. We also need to apply `stripslashes()` before trying to
 connect to a database.
 * Due to [18578], we need to set `<body class="rtl">` in both `setup-
 config.php` and `install.php` if `is_rtl()`. We don't have that function
 in `setup-config.php`, so we can check `$text_direction` itself.

 Uploaded [attachment:18180.3.diff] for further review.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18180#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software