[wp-trac] [WordPress Trac] #18510: Class properties dbpassword, dbname, dbhost and dbh are undefined in wpdb

[WordPress Trac]

#18510: Class properties dbpassword, dbname, dbhost and dbh are undefined in wpdb
------------------------------------+------------------------------
 Reporter:  joelhardi               |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Database                |     Version:  3.3
 Severity:  minor                   |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------------------

Comment (by joelhardi):

 I totally agree with you, but that should probably be submitted as a
 separate issue ... you can create a new ticket and link to it here.

 I think it's better to keep this issue focused on adding the docstrings
 and variable declarations for the missing vars.

 WP core team has a particular strategy for when they want to move things
 to PHP5 (i.e. only when it really adds something, not just to break
 compatibility with PHP4), and I don't think that discussion makes sense
 here where there's a much narrower bug (missing vars).

 Also, in your patch you might as well replace all the `var` statements
 with whatever the visibility is supposed to be (since this info is already
 in the doc strings) ... no point in doing it halfway, mixing `var` with
 `public/protected/private` is just going to confuse anyone else working on
 the file. Like I said, personally I agree with you and support your patch,
 the sooner WP starts enforcing member visibility the better IMHO.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18510#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software