[wp-trac] [WordPress Trac] #18156: Removing similar strings in Twenty Eleven

[WordPress Trac]

#18156: Removing similar strings in Twenty Eleven
---------------------------+--------------------
 Reporter:  pavelevap      |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.3
Component:  Bundled Theme  |     Version:  3.2.1
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+--------------------
Changes (by SergeyBiryukov):

 * milestone:  Awaiting Review => 3.3


Comment:

 Replying to [comment:3 nacin]:
 > "Leave a Reply" looks like it should be standardized to "Leave a reply".

 [attachment:18156.patch] does just that.

 Replying to [ticket:18156 pavelevap]:
 > But previous_image_link() function does not allow HTML in text.

 Escaping in `wp_get_attachment_link()` was introduced in [10495] along
 with the `$text` parameter itself and changed to `esc_attr()` in [11204].
 Looks like it shouldn't really be there:

 1. `$link_text` is not an attribute, it's literally a link text.
 2. `adjacent_post_link()` doesn't escape link text.

 So [attachment:18156.2.patch] addresses the last point of the ticket as
 well.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18156#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software