[wp-trac] [WordPress Trac] #15911: Comment Quick Edit quirks

[WordPress Trac]

#15911: Comment Quick Edit quirks
--------------------------+-----------------------
 Reporter:  garyc40       |       Owner:  garyc40
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.3
Component:  Comments      |     Version:  3.0
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 When cancelling Quick Edit form with some open tags in it, calling
 `closeAllTags()` from `commentReply.close()` floods Firefox JS console
 (6.0/Windows, tried without extensions too) with errors:
 {{{
 Error: uncaught exception: [Exception... "Component returned failure code:
 0x80004005 (NS_ERROR_FAILURE)
 [nsIDOMNSHTMLTextAreaElement.selectionStart]"  nsresult: "0x80004005
 (NS_ERROR_FAILURE)"  location: "JS frame :: http://trunk.wordpress/wp-
 includes/js/quicktags.dev.js?ver=20110820 :: <TOP_LEVEL> :: line 410"
 data: no]
 }}}
 And the comment disappears until page reload.

 If it's called earlier (e.g. before `fadeOut()` in
 `commentReply.revert()`), everything works as expected, though we can
 briefly see the tags closing, and these changes will be discarded anyway.

 That's why I thought about just clearing button states, without touching
 `replycontent` if it's invisible.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15911#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software