[wp-trac] [WordPress Trac] #18476: Duplicate code in filesystem classes

WordPress Trac wp-trac at lists.automattic.com
Thu Aug 18 23:20:01 UTC 2011


#18476: Duplicate code in filesystem classes
--------------------------+------------------------------
 Reporter:  kurtpayne     |       Owner:  kurtpayne
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Filesystem    |     Version:  3.2.1
 Severity:  minor         |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------------------

Comment (by kurtpayne):

 Replying to [comment:2 nacin]:
 > I noticed this recently. The base class is also missing a number of
 methods that some or all of the  others then define. It would be much
 better if they listed the method as a point of reference for what the
 WP_Filesystem API is capable of.

 What if the implementations in the base class were the same as the
 implementations in the direct access class?  This would accomplish the
 goal of giving a reference implementation for each method.  The direct
 access class would be essentially empty, but open for future extension,
 and the API would remain intact.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18476#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list