[wp-trac] [WordPress Trac] #18298: deprecate TEMPLATEPATH and STYLESHEETPATH
WordPress Trac
wp-trac at lists.automattic.com
Thu Aug 18 19:32:15 UTC 2011
#18298: deprecate TEMPLATEPATH and STYLESHEETPATH
---------------------------+------------------------------
Reporter: aaroncampbell | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: has-patch |
---------------------------+------------------------------
Comment (by chipbennett):
Replying to [comment:14 toscho]:
> Replying to [comment:12 aaroncampbell]:
> > I think that what he's saying is that you'd have to build some sort of
regex to look for the constant being used
>
> Impossible. PHP is more complex than PCRE, so you’d have to use a
tokenizer. Just think about constants in comments … ;)
Which would be just fine for Theme Check. It ignores anything in PHP
comments. Also, even if it finds false-positives, that's okay. Most such
output is listed as '''INFO''' anyway: meant as a hint to the
developer/reviewer to verify that its usage is proper.
In any case, this rabbit trail has strayed far from the intent of the
ticket. I'll take it offline with Pross, and if he comes up with something
viable for Theme Check, then I will take a look at the rest of the defined
constants with `@deprecated`, to see if any could benefit from additional
deprecation information, and submit a separate patch.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18298#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list