[wp-trac] [WordPress Trac] #17552: Plugin editor incorrectly calls some files inactive.

[WordPress Trac]

#17552: Plugin editor incorrectly calls some files inactive.
--------------------------+-----------------------------
 Reporter:  dd32          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Plugins       |     Version:  3.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------------

Comment (by dd32):

 Replying to [comment:2 solarissmoke]:
 > Seems to have been caused by a typo - the `$plugin` variable was being
 assigned to `$_REQUEST['file']` instead of `$_REQUEST['plugin']`.

 Oddly enough, As much as it looks like a typo, it's not just a typo there,
 $file is referenced to as both the file being currently edited, and as the
 plugin being edited.. it looks like it was to fix the problem of $file not
 containing $plugin in many places (If you don't follow that, don't
 worry..)

 > @dd32 I couldn't reproduce/understand the issue with
 `$_GET['plugin']`... With the patch I just posted, things seem to work
 fine?

 Sorry i didn't get back to you at the time, but yeah, I no longer see that
 problem after patching the editor code, started off with your patch and it
 grew as i noticed issues.. but never noticed that problem..

 Work in progress patch showing what I've come up against attached

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17552#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software