[wp-trac] [WordPress Trac] #17198: New theme for 3.next -- Twenty Eleven

WordPress Trac wp-trac at lists.automattic.com
Thu Apr 28 08:07:00 UTC 2011


#17198: New theme for 3.next -- Twenty Eleven
-------------------------+------------------
 Reporter:  matt         |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.2
Component:  Themes       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------

Comment (by nacin):

 (In [17733]) Rewrite of Twenty Eleven theme-options.php. Including:
  * Full inline documentation.
  * Enqueue scripts/styles on admin_enqueue_scripts and use hook_suffix
 rather than GET[page]
  * Add filters to twentyeleven_color_schemes(), twentyeleven_layouts(),
 which necessitates adding a thumbnail URL value here, rather than
 generating them in the form.
  * Add a twentyeleven_default_theme_options filter.
  * Remove manual check for REQUEST[settings-updated], instead using
 settings_errors(), since we're using options.php.
  * Abstract out the default link color, rather than hardcoding it in
 certain places.
  * Use checked().
  * Rename some variables and functions for clarity.
  * Remove unnecessary functions twentyeleven_current_layout() and
 twentyeleven_current_color_scheme(), as we already have
 twentyeleven_get_theme_options().
  * Add a twentyeleven_color_schemes action to allow for enqueueing custom
 color schemes.
  * Add a twentyeleven_layout_classes filter, to allow filtering what gets
 sent back to body_class().
  * Hook into wp_enqueue_scripts rather than wp_print_styles for enqueueing
 the color stylesheet.
  * Rewrite the register_setting() callback to start from scratch with an
 empty array. Improve the link_color logic.
  * Use submit_button().
  * Use esc_attr() rather than esc_attr_e() for non-translations.

 TODO:
  * Implement settings sections/fields logic to allow extension of the
 options page.
  * Consider re-doing this in a class. It'll be cleaner.
  * Store a DB version so we can do an add_option(), rather than calling
 get_option() with defaults.

 see #17198.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17198#comment:57>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list