[wp-trac] [WordPress Trac] #17224: Incorrect handling of PclZip's errors

[WordPress Trac]

#17224: Incorrect handling of PclZip's errors
-----------------------------+-----------------
 Reporter:  dd32             |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  3.2
Component:  Upgrade/Install  |    Version:
 Severity:  normal           |   Keywords:
-----------------------------+-----------------
 PclZip::extract() returns an array or 0 on failure, the latest docs
 avaialable here: http://www.phpconcept.net/pclzip/user-guide/55 spell that
 out clearly.

 Currently in core we check for (bool)false only, resulting in a few PHP
 Notices and unneeded processing of some code.

 Solution here is to change it to !is_array(), as anything other than an
 array is going to be a failure.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17224>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software