[wp-trac] [WordPress Trac] #17160: Static WP_I18N strings in wp-load

[WordPress Trac]

#17160: Static WP_I18N strings in wp-load
--------------------------+-----------------------
 Reporter:  niallkennedy  |       Owner:
     Type:  enhancement   |      Status:  reopened
 Priority:  normal        |   Milestone:
Component:  I18N          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by niallkennedy):

 Replying to [comment:3 sivel]:
 > Please do not over write patches when attaching a new patch.  Doing so
 does not allow others to understand the context of comments made in
 regards to previous patches.  If you do not select to replace, it will
 automatically increment the patch number or you can handle this on your
 own.

 Sorry for creating confusion.

 The original patch changed three strings in wp-load from dynamic strings
 to static strings: WP_I18N_TEXT_DIRECTION; WP_I18N_NO_CONFIG;
 WP_I18N_ERROR_TITLE.

 Westi noted my proposed change to WP_I18N_NO_CONFIG requires escaping the
 apostrophe in "doesn't" and therefore
 [http://codex.wordpress.org/WordPress_Coding_Standards#Single_and_Double_Quotes
 violates the WordPress Coding Standards].

 The other two strings do not contain an apostrophe and therefore should be
 eligible for a change to a static string.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17160#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software