[wp-trac] [WordPress Trac] #16748: wp_die() should return proper errors when called from xmlrpc

WordPress Trac wp-trac at lists.automattic.com
Sun Apr 17 15:30:53 UTC 2011


#16748: wp_die() should return proper errors when called from xmlrpc
--------------------------------------------+-----------------------
 Reporter:  koke                            |       Owner:  westi
     Type:  defect (bug)                    |      Status:  accepted
 Priority:  normal                          |   Milestone:  3.2
Component:  XML-RPC                         |     Version:  3.1
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch mobile needs-testing  |
--------------------------------------------+-----------------------

Comment (by ericmann):

 Replying to [comment:11 westi]:
 > Using a closure instead of a function to hook this in isn't as it makes
 it really hard to {{{remove_filter}}} the function.

 I can accept that.  And I like the actual commit patch even better.

 > Also I think we shouldn't define the function in xmlrpc.php - someone
 might want to re-use it when serving xmlrpc requests on a different
 endpoint.

 I think defining a different XMLRPC endpoint would be an extreme edge
 case, and since the custom function was specific to our XMLRPC handler I
 figured that would be the best place to put it.  But thinking forward to
 the possibility of other custom `die()` handlers (I've seen a couple of
 custom REST systems in development) I think dropping it in `functions` is
 a better solution.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16748#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list