[wp-trac] [WordPress Trac] #10348: Include PHP-based SSH2 layer for those without the SSH2 PHP extension

WordPress Trac wp-trac at lists.automattic.com
Sat Apr 16 15:14:37 UTC 2011


#10348: Include PHP-based SSH2 layer for those without the SSH2 PHP extension
-------------------------------------+-----------------------
 Reporter:  blazerlocal              |       Owner:  dd32
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:
Component:  Filesystem               |     Version:  2.9
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |
-------------------------------------+-----------------------
Changes (by blazerlocal):

 * status:  closed => reopened
 * resolution:  wontfix =>


Comment:

 I completely disagree with the whole "lets get more hosts to work with the
 Direct class" idea.  The Direct class is crap.  You want hosts to use the
 Direct class?  How about you get the devs of libssh2 to actively maintain
 it again?  It took two years for it to start supporting PHP 5.3 and it
 only started supporting that when someone else came along and took it over
 from the old devs.  And that they can make it compile doesn't mean they're
 going to be able to fix bugs with the implementation itself.

 And the API just plain sucks.  Private keys have to be saved on the
 filesystem to be loaded whereas with phpseclib all they need be is
 strings.  You can take a key from $_POST without having to dump it to the
 filesystem as libssh2 requires.  To top it off, libssh2 requires you have
 a separate file for the publickey, which is brain dead, since the private
 key *contains* the public key.

 ssh2_exec(), from libssh2, also returns ANSI color codes and sometimes
 never returns output and sometimes does (it's inconsistent).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10348#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list