[wp-trac] [WordPress Trac] #16748: wp_die() should return proper errors when called from xmlrpc
WordPress Trac
wp-trac at lists.automattic.com
Tue Apr 12 16:11:25 UTC 2011
#16748: wp_die() should return proper errors when called from xmlrpc
------------------------------+-----------------------
Reporter: koke | Owner: westi
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 3.2
Component: XML-RPC | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch mobile |
------------------------------+-----------------------
Comment (by ericmann):
I like your solution, and I think the location is accurate since we're
hooking in to the `wp_die_handler` filter. The only thing I would
recommend is changing the method name to `xmlrpc_die_handler()` for
consistency (since the default is `_default_wp_die_handler`). I'd hate
for some unsuspecting developer to call `xmlrpc_wp_die()` directly rather
than `wp_die()`.
Attaching a slightly modified patch that changes the method name and uses
a simpler filter return.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16748#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list