[wp-trac] [WordPress Trac] #17097: make_clickable() regex should exclude close-quotation marks after URLs
WordPress Trac
wp-trac at lists.automattic.com
Mon Apr 11 12:27:16 UTC 2011
#17097: make_clickable() regex should exclude close-quotation marks after URLs
--------------------------+------------------------------
Reporter: boonebgorges | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 3.1
Severity: minor | Resolution: invalid
Keywords: close |
--------------------------+------------------------------
Changes (by boonebgorges):
* status: new => closed
* resolution: => invalid
Comment:
{{{
http://example.com?foo=bar’ looks like a valid URL to me.
}}}
Yeah, I guess that's right. Though my related issue is that, given the
input string http://example.com?foo=bar’, which of the following
outcomes is more likely to be expected:
<a
href="http://example.com?foo=bar’">http://example.com?foo=bar’</a>;
or
<a
href="http://example.com?foo=bar’">http://example.com?foo=bar’</a>
(FWIW, Trac is doing the same thing as WP here and excluding the semi-
colon. So I'm probably just wrong.)
{{{
make_clickable runs on comment_text at 9, just before wptexturize. I would
consider that to be a requirement for its use.
}}}
I'm referring to the use of make_clickable in a plugin, outside of
comment_text. So I guess the answer is probably just that I'm doing it
wrong, and should make sure that it runs before wptexturize. Thanks for
your help.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/17097#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list