[wp-trac] [WordPress Trac] #16961: Custom Background Color Input/Dialog in Twenty Ten

WordPress Trac wp-trac at lists.automattic.com
Thu Apr 7 12:17:57 UTC 2011

#16961: Custom Background Color Input/Dialog in Twenty Ten
 Reporter:  hakre                    |       Owner:  jakub.tyrcha
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Themes                   |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |

Comment (by jakub.tyrcha):

 Thanks for the input :) As for your remarks:
 * This doesn't seem to work - Chrome does OK with it, but Firefox throws
 * I need it, it's used 4 lines later - the reason for getting the document
 height >before< showing the color picker, is that if the color picker
 expands lower than the current document, the document height increases and
 we can't determine how much. IMHO this one should stay this way
 * Good call, thanks
 * No, actually - it doesn't. A normal procedure for positioning an element
 is unsetting its display value from "none" and setting the position with
 the same command set. However, commands in JavaScript are not executed one
 after another but in parallel, so since we do almost no operations between
 showing the element and setting its position, the delay should be lower
 than the rendering time (and from my observations, it is)
 * fixed. there is still the +2/+10 thing, but it can't be fixed, because
 it's just visual styling - we don't want to have the colorpicker fit the
 input border

 how is the new patch?

Ticket URL: <http://core.trac.wordpress.org/ticket/16961#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list