[wp-trac] [WordPress Trac] #16961: Custom Background Color Input/Dialog in Twenty Ten

[WordPress Trac]

#16961: Custom Background Color Input/Dialog in Twenty Ten
-------------------------------------+------------------------------
 Reporter:  hakre                    |       Owner:  jakub.tyrcha
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Themes                   |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------

Comment (by nacin):

 We should be able to improve this a bit:

  - Pass $ to the function, preventing us from using jQuery internally.
  - Don't set up window_height if you don't need it.
  - Initialize colorpicker_offset with var.
  - I imagine this makes it jump/flicker, by showing then moving. Any way
 we can prevent that?
  - Any way we can also calculate the height of the color wheel, rather
 than magic numbers?

 Just a first glance.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16961#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software