[wp-trac] [WordPress Trac] #17064: Upgrade SquirrelMail POP3 class

[WordPress Trac]

#17064: Upgrade SquirrelMail POP3 class
---------------------------+------------------------------
 Reporter:  aaroncampbell  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  General        |     Version:  3.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------------------

Comment (by aaroncampbell):

 The code was taken straight from http://squirrelmail.org/docs/stable-
 code/__filesource/fsource_plugins_mail_fetch_pluginsmail_fetchclass.POP3.php.html

 The main changes seem to be the replacement of ereg/eregi with preg_match,
 strpos, and stripos (for which they add a PHP4 compatibility bit at the
 end of the file...we could remove this if we so desire).  They also
 switched to using `$line{0}` instead of `$line[0]` to get the first
 character of a string, and combined two str_replace calls into one.

 All in all it looks to be a really clean drop-in that shouldn't hurt
 anything.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17064#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software