[wp-trac] [WordPress Trac] #16955: It's tricky to drag metaboxes
WordPress Trac
wp-trac at lists.automattic.com
Tue Apr 5 20:47:39 UTC 2011
#16955: It's tricky to drag metaboxes
----------------------------+------------------------
Reporter: scribu | Owner:
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 3.1.2
Component: Administration | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+------------------------
Comment (by JDTrower):
So I tracked down the offending code to ui.sortable.js. The change that
caused this flickering was introduced in jQuery UI 1.8. Specifically it
was the removal of the following code from ui.sortable.js:
{{{
//We ignore calculating positions of all connected containers when we're
not over them
if(item.instance != this.currentContainer && this.currentContainer &&
item.item[0] != this.currentItem[0])
continue;
}}}
The relevant jQuery UI Trac ticket is
[http://bugs.jqueryui.com/ticket/4551] and the relevant jQuery UI GitHub
commit is [https://github.com/jquery/jquery-
ui/commit/56b0da59d71396a740cf48a75902243d561ba186].
I found that by re-adding the code they removed in this commit fixed our
problem all the way through to the latest release of jQuery UI 1.8.11.
Obviously hacking this file to re-add this code isn't ideal, but I'm
unsure if this is a bug in jQuery UI or a bug in WordPress in how we
implement the usage of jQuery UI. I can provide a patch to current trunk
that re-adds the removed code if someone wants to test it, and I can
provide a patch to update jQuery UI to 1.8.11 with the removed code re-
added, if anyone is interested.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16955#comment:28>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list