[wp-trac] [WordPress Trac] #16303: Improve documentation and usability of WP_Rewrite Endpoint support

[WordPress Trac]

#16303: Improve documentation and usability of WP_Rewrite Endpoint support
-----------------------------------+--------------------
 Reporter:  westi                  |       Owner:  westi
     Type:  defect (bug)           |      Status:  new
 Priority:  lowest                 |   Milestone:  3.2
Component:  Rewrite Rules          |     Version:  3.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch westi-likes  |
-----------------------------------+--------------------

Comment (by hakre):

 Just reviewd the patch and refreshed against trunk, my 2 cents:

  * As written in comments, the Bitmask is OR'ed. That's what common as
 well ([http://php.net/manual/en/function.error-reporting.php PHP Example])
  * There is no vartype "bitmask" (isn't it int?, see notes)
  * Adding an endpoint does always mean a new endpoint (tautological).
  * It's 3.2.0 now.

 Additional notes:

  * EP_ALL can be safely defined as 16 383, that spares the calculation.
  * Same for EP_ALL_ARCHIVES, can be pre-calculated as well (documentation
 could show what value stands for)
  * About the missing use of the define dd32 was pointing westi to I have
 no clue.

 westi: WP_Rewrite::add_endpoint() had documented the `$places` as an
 array, you changed that to bitmask (and I to int because I think bitmasks
 are ints). What PHP vartype is that `$places` parameter of the said
 function?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16303#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software