[wp-trac] [WordPress Trac] #16606: WP_Http_Streams::test doesn't check enough to confirm if it can do HTTPS
WordPress Trac
wp-trac at lists.automattic.com
Sat Apr 2 20:08:53 UTC 2011
#16606: WP_Http_Streams::test doesn't check enough to confirm if it can do HTTPS
---------------------------------+-----------------------------
Reporter: westi | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: Future Release
Component: HTTP | Version: 3.0.5
Severity: major | Resolution:
Keywords: 3.2-early has-patch |
---------------------------------+-----------------------------
Comment (by mdawaffe):
Replying to [comment:7 hakre]:
> Replying to [comment:6 mdawaffe]:
> > What's the use case for the filter when {{{function_exists( 'fopen'
)}}} returns {{{false}}}?
>
> Hooks can still filter it. E.g. reporting, enable / creating functions
etc. (dl etc.).
OK.
The {{{curl_version()}}} (with falllback to {{{extension_loaded( 'openssl'
)}}}) check in [attachment:16606.5.diff 16606.5.diff] is a better check
for the ability to make an SSL request in {{{WP_Http_Curl}}}.
PS: for the inflate code, rather than changing
{{{WP_Http_ExtHttp::request()}}}, should
{{{WP_Http_Encoding::decompress()}}} just use {{{http_inflate}}} if it's
available and supported?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16606#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list