[wp-trac] [WordPress Trac] #16606: WP_Http_Streams::test doesn't check enough to confirm if it can do HTTPS

[WordPress Trac]

#16606: WP_Http_Streams::test doesn't check enough to confirm if it can do HTTPS
---------------------------------+-----------------------------
 Reporter:  westi                |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  high                 |   Milestone:  Future Release
Component:  HTTP                 |     Version:  3.0.5
 Severity:  major                |  Resolution:
 Keywords:  3.2-early has-patch  |
---------------------------------+-----------------------------
Changes (by mdawaffe):

 * cc: mdawaffe (added)


Comment:

 What's the use case for the filter when {{{function_exists( 'fopen' )}}}
 returns {{{false}}}?

 Can we turn this into a generic ticket that adds an SSL check to the
 {{{::test()}}} methods for all the WP_HTTP transports?

 Attached does so, but does not have some of the additional checks of
 hakre's patch (I wrote it before finding this ticket).

  1. Return false if the required function doesn't exist or could never
 work.
  2. Check for the openssl extension or CURL_VERSION_SSL as needed.
  3. Return filtered boolean.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16606#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software