[wp-trac] [WordPress Trac] #14976: WP_Query's init() and init_query_flags() do not do thorough resets

WordPress Trac wp-trac at lists.automattic.com
Wed Sep 29 14:40:35 UTC 2010


#14976: WP_Query's init() and init_query_flags() do not do thorough resets
------------------------------------+---------------------------------------
 Reporter:  coffee2code             |        Owner:        
     Type:  defect (bug)            |       Status:  closed
 Priority:  normal                  |    Milestone:  3.1   
Component:  Query                   |      Version:  3.0.1 
 Severity:  minor                   |   Resolution:  fixed 
 Keywords:  has-patch dev-feedback  |  
------------------------------------+---------------------------------------

Comment(by coffee2code):

 I agree that the unsetting of the public properties was a bit unusual.  I
 personally would have set them to null.  However, the existing convention
 in the function was to unset properties that were defined but not given an
 initial value, otherwise re-initialize those that were assigned an initial
 value.  I figured the existing convention warranted a separate discussion,
 so I rolled with what was there.  But I with you on that count.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14976#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list