[wp-trac] [WordPress Trac] #14963: Plugin update shouldn't delete package from local filesystem

WordPress Trac wp-trac at lists.automattic.com
Sun Sep 26 03:38:15 UTC 2010

#14963: Plugin update shouldn't delete package from local filesystem
 Reporter:  joelhardi    |       Owner:                        
     Type:  enhancement  |      Status:  new                   
 Priority:  normal       |   Milestone:  Awaiting Review       
Component:  Plugins      |     Version:  3.1                   
 Severity:  normal       |    Keywords:  has-patch dev-feedback
 While working on #14915 I discovered a small separate issue.

 Currently, when upgrading a plugin, the package (zip) file is extracted to
 the filesystem and then deleted, no matter what the source of the file is.

  * Remotely fetched packages, after they're extracted, are deleted from
 their temporary location (which is fine, that's garbage collection).

  * Local files, however, are also deleted from wherever they happen to be.
 I don't think that it's right to silently unlink from the user's local
 filesystem like this. If I've got a file sitting on my local system
 (especially outside !WordPress' file tree) I don't expect !WordPress to
 delete it (without asking).

 I doubt this issue has come up as I can't imagine it affects many people
 (who has or would manually download a plugin package and then hack the
 !WordPress upgrader to install it, instead of just unzipping into the
 plugins folder?). Nevertheless I think it's undesirable behavior, and the
 attached patch is a trivial enhancement.

Ticket URL: <http://core.trac.wordpress.org/ticket/14963>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list