[wp-trac] [WordPress Trac] #14955: Themes should support uninstall.php or uninstall hook
WordPress Trac
wp-trac at lists.automattic.com
Fri Sep 24 00:35:32 UTC 2010
#14955: Themes should support uninstall.php or uninstall hook
-------------------------+--------------------------------------------------
Reporter: WraithKenny | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Themes | Version: 3.0.1
Severity: normal | Keywords:
-------------------------+--------------------------------------------------
Description changed by scribu:
Old description:
> Related tickets on extending Themes to have Plugin features: #7795 and
> #14849 but those deal primarily with activation and deactivation
> centering around 'switch_themes' action.
>
> From looking at /wp-admin/includes/plugin.php, adding support for
> uninstall is a separate concern (and it doesn't have the issue blocking
> activation/deactivation).
>
> Should is_uninstallable_plugin, register_uninstall_hook and
> uninstall_plugin be extended to check theme directory or should versions
> (is_uninstallable_plugin, register_uninstall_theme_hook and
> uninstall_plugin) be added to theme.php?
>
> Advantage of the first method is that the register_uninstall_hook could
> be reused for Themes where in the second, a new, less attractive name
> would be needed (register_uninstall_theme_hook?) Also, there's no
> theme_basename as it was reverted/removed.
New description:
Related tickets on extending Themes to have Plugin features: #7795 and
#14849 but those deal primarily with activation and deactivation centering
around 'switch_themes' action.
From looking at /wp-admin/includes/plugin.php, adding support for
uninstall is a separate concern (and it doesn't have the issue blocking
activation/deactivation).
Should is_uninstallable_plugin, register_uninstall_hook and
uninstall_plugin be extended to check theme directory or should versions
(is_uninstallable_theme, register_uninstall_theme_hook and
uninstall_theme) be added to theme.php?
Advantage of the first method is that the register_uninstall_hook could be
reused for Themes where in the second, a new, less attractive name would
be needed (register_uninstall_theme_hook?) Also, there's no theme_basename
as it was reverted/removed.
--
--
Ticket URL: <http://core.trac.wordpress.org/ticket/14955#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list