[wp-trac] [WordPress Trac] #7763: CSS for login/register page could be more robust
WordPress Trac
wp-trac at lists.automattic.com
Wed Sep 22 14:50:45 UTC 2010
#7763: CSS for login/register page could be more robust
----------------------------+-----------------------------------------------
Reporter: richardkmiller | Owner: Nicholas91
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: UI | Version: 3.1
Severity: minor | Keywords: has-patch needs-testing dev-feedback
----------------------------+-----------------------------------------------
Changes (by joelhardi):
* keywords: has-patch gsoc needs-testing => has-patch needs-testing dev-
feedback
Comment:
Just a retag in hopes of reviving this old bug up (please chastise me if
I'm abusing the bug tracker) and getting a commit.
This seems like a pretty minor change. The username, email and password
fields already have {{{class="input"}}} so it's simply a matter of
applying the style to this class rather than to the individual {{{id}}} of
every single text input on the form. No HTML edits necessary.
To me, this is a CSS/markup best practice, and as a plugin dev it means I
can add additional fields to these forms (i.e. if I want to allow the user
to register a URL, or want to require a captcha) and just do
{{{class="input"}}} to get them to match the style of the other input
fields. It also means I can change the HTML ID attributes of these fields
if I need to (for instance, I have an anti-reg spam reason for doing this)
without them losing their styling.
I've tested my patch across all browsers and don't see where there could
be any breakage or bad side effects. The new CSS declaration is just a
straight-up CSS1 descendant selector that's been supported since at least
IE 5.5. And it saves 20 bytes.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/7763#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list