[wp-trac] [WordPress Trac] #14920: Noop function called and WP_Dependencies constructors conceptually broken

[WordPress Trac]

#14920: Noop function called and WP_Dependencies constructors conceptually broken
--------------------------+-------------------------------------------------
 Reporter:  hakre         |       Owner:                 
     Type:  defect (bug)  |      Status:  new            
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:                 
 Severity:  normal        |    Keywords:  has-patch      
--------------------------+-------------------------------------------------

Comment(by hakre):

 Replying to [comment:3 filosofo]:
 > Replying to [ticket:14920 hakre]:
 > [...]
 I read your comment that you assume that it's wanted to provide
 `__construct()` as a constructor. But this is not needed. No-one needs
 this "hack", it's just added code that can be saved.

 Sure it can be refactored after a switch to PHP 5 (saving it as well) at
 least then (with the switch to PHP 5) it's obvious for everybody.

 Until then it remains in there throwing sand into the readers eyes as if
 this had some special meaning. It's just a bad written constructor
 construct that can be better implemented by using the existing language
 feature w/o re-inventing the wheel. The patch just showing a way how.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14920#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software