[wp-trac] [WordPress Trac] #14840: Constant UPLOADS not working for the main site if MULTISITES is not enabled

[WordPress Trac]

#14840: Constant UPLOADS not working for the main site if MULTISITES is not enabled
--------------------------+-------------------------------------------------
 Reporter:  Axel_germany  |       Owner:       
     Type:  defect (bug)  |      Status:  new  
 Priority:  high          |   Milestone:  3.0.2
Component:  Upload        |     Version:  3.1  
 Severity:  major         |    Keywords:       
--------------------------+-------------------------------------------------
Changes (by nacin):

  * severity:  normal => major
 * cc: wpmuguru (added)
  * component:  General => Upload
  * priority:  normal => high
  * milestone:  Awaiting Review => 3.0.2
  * keywords:  CONSTANT UPLOADS, no Multisite, main blog =>


Comment:

 I see what's going on here.

 We utilize a conditional defined('MULTISITE') check not to check if the
 site is running multisite, but if the site is running multisite AND is not
 an upgraded MU installation. In select cases, we handle MU and 3.0
 multisite installs differently.

 When we forced MULTISITE to always be defined in [14000], I didn't take
 into account this.

 We could introduce a is_legacy_multisite() function that we can use for
 select defined('MULTISITE') checks, as I'm afraid this isn't the only
 location that has this code. I think the only other instance however is
 wpdb::get_blog_prefix, which should be fired prior to us defining
 MULTISITE as false. So it works in that instance.

 If we add an is_multisite() check to $main_override, this bug is fixed.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14840#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software