[wp-trac] [WordPress Trac] #14837: Themes should allow custom headers to be selectable, but not uploadable
WordPress Trac
wp-trac at lists.automattic.com
Fri Sep 10 17:28:54 UTC 2010
#14837: Themes should allow custom headers to be selectable, but not uploadable
-------------------------+--------------------------------------------------
Reporter: jorbin | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Themes | Version:
Severity: minor | Keywords: has-patch
-------------------------+--------------------------------------------------
Comment(by jorbin):
Replying to [comment:2 nacin]:
> Possible better way of implementing this: We should instead register
theme support for "custom-header-uploads" by default, and allow the theme
to remove said theme support as a way to enable this.
>
That makes sense. I'll update the patch accordingly.
> Replying to [comment:1 ericmann]:
> > Honestly, if a theme doesn't want to support the uploading of custom
headers, that's up to the theme ... why does this patch need to be in
core? I don't see the point.
Exactly, it should be up to the theme. Right now it's not even an option.
Custom headers are all or nothing.
>
> Because the theme would still want the ability for registered headers to
be chosen. Currently the custom-header UI won't support that.
>
> I see use cases here for sure. Not a good idea for a distributed theme,
but rather in instances where a user on a site might be allowed to
edit_theme_options but should not be allowed to modify anything beyond
what the admins have specifically set up for the site.
Another use case I see is being on Multi Site networks that want to offer
a range of branded headers, but not wanting to give the user the option to
upload an unbranded one.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/14837#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list