[wp-trac] [WordPress Trac] #14786: WP_Http Transport test order refactoring (was: It's WP_Http_ExtHTTP not WP_Http_ExtHttp)
WordPress Trac
wp-trac at lists.automattic.com
Mon Sep 6 14:25:46 UTC 2010
#14786: WP_Http Transport test order refactoring
--------------------------+-------------------------------------------------
Reporter: hakre | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: HTTP | Version: 3.0.1
Severity: normal | Keywords: has-patch dev-feedback
--------------------------+-------------------------------------------------
Comment(by hakre):
I now incorporated the feedback partially.
* The iterator over multiple contexts inside the function as commented on
by dd32 is strictly taken not necessary. I've removed it to make the
function more clear.
* WP_Http_Fopen::test() now returns false on any request methods other
than the default 'GET' one. This is based on dd32's feedback as well.
* The test order is now defined in the WP_Http class and can be filtered
per each context.
* If multiple transports should be allowed/returned as suggested in #8622
patch [http://core.trac.wordpress.org/attachment/ticket/8622/8622.3.diff
8622.3.diff], then the {{{break;}}} needs to be removed.
* The design limitations as discussed in #11613 are not dealt with so
far. But The changes so far should make it more easily to add such a
functionality.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/14786#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list