[wp-trac] [WordPress Trac] #14759: Improve the way oEmbed deals with caching

WordPress Trac wp-trac at lists.automattic.com
Wed Sep 1 23:48:59 UTC 2010


#14759: Improve the way oEmbed deals with caching
--------------------------+-------------------------------------------------
 Reporter:  Viper007Bond  |       Owner:                 
     Type:  enhancement   |      Status:  new            
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Embeds        |     Version:  3.0.1          
 Severity:  normal        |    Keywords:                 
--------------------------+-------------------------------------------------
Description changed by Viper007Bond:

Old description:

> As Matt pointed to me today, caching oEmbed results to post meta is kinda
> lame.
>
> I originally did this because I didn't want the HTML in old posts
> changing on it's own (say for example if the oEmbed provider got
> compromised). However I think that's extremely unlikely since we only
> whitelist major websites that can be trusted.
>
> Perhaps instead we should use transients to cache this data. That way
> when embed HTML is updated, posts will eventually be updated too.
>
> A good example of this is Vimeo. Anyone who embedded a Vimeo embed in
> their post before a few weeks ago got `<object>`-based embeds. However
> now Vimeo gives out `<iframe>` based ones. The only way currently to do
> this (without a few lines of code) is to edit all of the posts and re-
> save them to trigger a cache update. That's lame.
>
> Alternate suggestions welcome though.

New description:

 As Matt pointed to me today, caching oEmbed results to post meta is kinda
 lame.

 I originally did this because I didn't want the HTML in old posts changing
 on it's own, say for example if the oEmbed provider got compromised.
 However I think that's extremely unlikely since we only whitelist major
 websites that can be trusted.

 Perhaps instead we should use transients to cache this data. That way when
 embed HTML is updated, posts will eventually be updated too due to
 expiring caches. I'm thinking a cache time of a week would be good, but
 with some random +/- to make sure multiple caches don't all expire at
 once.

 A good example of this is Vimeo. Anyone who embedded a Vimeo embed in
 their post before a few weeks ago got `<object>`-based embeds. However now
 Vimeo gives out `<iframe>` based ones. The only way currently to do this
 (without a few lines of code) is to edit all of the posts and re-save them
 to trigger a cache update. That's lame.

 Alternate suggestions welcome though.

--

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14759#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list