[wp-trac] [WordPress Trac] #14415: Major fail of the pages widget in the nav-menu admin page when having a lot of pages

[WordPress Trac]

#14415: Major fail of the pages widget in the nav-menu admin page when having a lot
of pages
--------------------------+-------------------------------------------------
 Reporter:  DreadLox      |        Owner:          
     Type:  defect (bug)  |       Status:  reopened
 Priority:  normal        |    Milestone:  3.1     
Component:  Menus         |      Version:  3.0     
 Severity:  normal        |   Resolution:          
 Keywords:  has-patch     |  
--------------------------+-------------------------------------------------
Changes (by duck_):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 This has also introduced a regression in the way multiple items of the
 same type are received. Previously you could add many Posts, for example,
 to a menu at once; now you only the first checked gets added.

 The solution seems like it would be looping through the $_POST['menu-
 item'] array instead of just getting the first item with array_shift.
 Quick patch attached. Though this does change the $menu_data array
 received by `wp_save_nav_menu_items` to be non-negatively indexed
 (pre-[16096] had negative indexes), though I don't think this should
 matter since `menu-item-db-id` should still be empty but maybe needs some
 more thorough testing.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14415#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software