[wp-trac] [WordPress Trac] #14993: make_clickable issue with ! character in URL

[WordPress Trac]

#14993: make_clickable issue with ! character in URL
--------------------------+-------------------------------------------------
 Reporter:  lancewillett  |       Owner:  westi      
     Type:  defect (bug)  |      Status:  accepted   
 Priority:  high          |   Milestone:  3.1        
Component:  Formatting    |     Version:  3.0.1      
 Severity:  major         |    Keywords:  needs-patch
--------------------------+-------------------------------------------------

Comment(by norbertm):

 Looked deeply into this issue as well as the standards and it's much more
 about not having the proper URL matching pattern in make_clickable()
 rather than Twitter's new URLs.

 Currently everything following the protocol part is matched with a single
 expression which is not correct. We may want to open another issue for
 getting RFC 3986 compliant by matching part specific patterns. Once we are
 standards compliant, we can add the two additonal layers on the top of it
 that we have right now, specifically XSS protection and logic for trailing
 periods, commas etc.

 For a quick fix, submitting a patch very soon (including test cases) that
 adds the missing exclamation mark to the current pattern. This will avoid
 Twitter specific bug reports in 3.1.

 Will submit a ticket for proposing standards compliance as well.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14993#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software