[wp-trac] [WordPress Trac] #14772: Administration bar
WordPress Trac
wp-trac at lists.automattic.com
Thu Oct 28 06:22:27 UTC 2010
#14772: Administration bar
----------------------------+-----------------------------------------------
Reporter: rmccue | Owner: filosofo
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 3.1
Component: Administration | Version: 3.1
Severity: normal | Keywords: multisite, ongoing-project
----------------------------+-----------------------------------------------
Comment(by filosofo):
In `admin-bar.14772.diff` I've cleaned up a bunch of stuff for the admin
bar. `adminbar-files.tar.gz` has the actual files, in case that's easier
to handle than a patch.
* Moved the CSS to its own files, including rtl. It's no longer
dynamically generated.
* Menu nav dropdowns are handled by CSS, not JS. I've tested in all the
big browsers successfully, except for IE6. I don't think it's worth
messing with just for it, especially as it's had a degraded experience in
WP starting with 3.0.
* JS is reduced to just a few lines, with no library dependencies.
* On the non-debug menu, JS does the following:
* Replace the pre-filled search text.
* scroll down for hash URL queries.
* Append the admin bar as a child of the body element.
* I cleaned up the appearance and spacing of the code and eliminated a
bunch of unnecessary logic checks.
'''TODO'''
* I didn't try to clean up the debug file. I think it looks terrible and
doesn't belong in core.
* The `load_user_locale_translations` method in `WP_Admin_Bar` needs to
have WP.com-specific cruft removed, but I'm not sure what the cruft was
supposed to do, so I left it alone.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/14772#comment:71>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list