[wp-trac] [WordPress Trac] #15154: Generalizing styling for "Manage Themes" / "Install Themes" tabs
WordPress Trac
wp-trac at lists.automattic.com
Tue Oct 19 15:55:40 UTC 2010
#15154: Generalizing styling for "Manage Themes" / "Install Themes" tabs
--------------------------+-------------------------------------------------
Reporter: chrisbliss18 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: UI | Version: 3.1
Severity: normal | Keywords: has-patch
--------------------------+-------------------------------------------------
The tabs present in Appearance > Themes pages are a very nice design
element. I recently tried to recreate this in some editors that I'm
building to keep consistency with the present WP UI, but I found that one
specific styling selector was too specific to the application to allow for
generic use of the tabs.
The problem specifically relates to the following rule:
{{{
.themes-php .wrap h2, .theme-install-php .wrap h2 {
border-bottom: 1px solid #ccc;
padding-bottom: 0;
}
}}}
This rule applies the bottom border to complete the design of the tabs;
however, the selectors are completely specific to the pages the tabs are
currently used on in core. My attached patch simply changes this to a more
generic selector and adds the new class to the <h2> wrapper around the
tabs. The new rule is as follows:
{{{
h2.nav-tab-wrapper {
border-bottom: 1px solid #ccc;
padding-bottom: 0;
}
}}}
The new class is nav-tab-wrapper. I considered using nav-tab-bar but
decided on using wrapper since it stays consistent with the existing nav-
tabs/nav-tabs-wrapper naming scheme used for the Menus editor.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/15154>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list