[wp-trac] [WordPress Trac] #15134: WordPress should not try to remove theme's or plugin's directory recursively if the directory is a symlink

WordPress Trac wp-trac at lists.automattic.com
Sun Oct 17 12:17:42 UTC 2010


#15134: WordPress should not try to remove theme's or plugin's directory
recursively if the directory is a symlink
---------------------------------+------------------------------------------
 Reporter:  vladimir_kolesnikov  |        Owner:         
     Type:  defect (bug)         |       Status:  closed 
 Priority:  normal               |    Milestone:         
Component:  Upgrade/Install      |      Version:         
 Severity:  normal               |   Resolution:  wontfix
 Keywords:                       |  
---------------------------------+------------------------------------------

Comment(by vladimir_kolesnikov):

 Replying to [comment:5 scribu]:
 > Yes, it works because you're hardcoding the plugin basename. If you to
 use register_activation_hook() (which you should) it won't work.


 With the patch from http://core.trac.wordpress.org/ticket/13550 it will
 work anyway.

 OK, probably my use case is not good for this problem but I still think
 that WP should not follow symlinks when deleting directories because this
 can cause removal of the files the user is not expecting to have removed.
 And it just contradicts to Linux/UNIX tradition - if the plugin/theme/etc
 directory were removed with 'rm -r', 'rm' would not follow the link but
 would remove the symlink itself instead. Just my opinion.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15134#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list