[wp-trac] [WordPress Trac] #14903: Expand theme support removal for 3.0 features

WordPress Trac wp-trac at lists.automattic.com
Fri Oct 15 10:43:54 UTC 2010


#14903: Expand theme support removal for 3.0 features
----------------------------+-----------------------------------------------
 Reporter:  nacin           |       Owner:     
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.1
Component:  Themes          |     Version:  3.0
 Severity:  normal          |    Keywords:     
----------------------------+-----------------------------------------------

Comment(by Utkarsh):

 Replying to [comment:6 nacin]:
 > Instead of returning false as a consequence of the blacklist, we can do:
 >
 > `return apply_filters( "remove_theme_support_$feature", false );`
 >
 > Then someone (us) can hook in, and additionally return true if we are
 successful.
 >
 > Then it's trivial to just `add_action( 'remove_theme_support_custom-
 background', 'remove_custom_background' );`
 >
 > I agree with you about the callback, but we still need to know the name
 of the callback, otherwise we can't remove the action. (At which point I'm
 not sure my add_action is a perfect idea, either, but then again, they can
 then just use remove_custom_background.)

 If we do this, adding custom header would be add_custom_header call, and
 removing would require remove_theme_support call. Only a
 remove_custom_header do it.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14903#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list